[
https://issues.apache.org/jira/browse/HBASE-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103752#comment-13103752
]
Ted Yu commented on HBASE-4153:
-------------------------------
{code}
+ private State extractRegionState(RegionAlreadyInTransitionException t) {
+ if (t.getMessage().contains("open")) {
{code}
I think the above check is a little fragile, considering the exception message
from HRegionServer:
{code}
+ throw new RegionAlreadyInTransitionException("Received open" +
+ " for region we are" + " already " +
+ (actionType ? "opening" : "closing") + "; " +
+ region.getRegionNameAsString());
{code}
The string to be matched should be longer. And javadoc should be added to the
above code in HRegionServer highlighting the phrase used in the check so that
next person modifying the exception message knows what not to break.
> Handle RegionAlreadyInTransitionException in AssignmentManager
> --------------------------------------------------------------
>
> Key: HBASE-4153
> URL: https://issues.apache.org/jira/browse/HBASE-4153
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0
>
> Attachments: HBASE-4153_1.patch
>
>
> Comment from Stack over in HBASE-3741:
> {quote}
> Question: Looking at this patch again, if we throw a
> RegionAlreadyInTransitionException, won't we just assign the region elsewhere
> though RegionAlreadyInTransitionException in at least one case here is saying
> that the region is already open on this regionserver?
> {quote}
> Indeed looking at the code it's going to be handled the same way other
> exceptions are. Need to add special cases for assign and unassign.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
