[ 
https://issues.apache.org/jira/browse/HBASE-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234865#comment-14234865
 ] 

Jonathan Hsieh commented on HBASE-12629:
----------------------------------------

it is undocumented and not really ever tested when set to false.  I was 
reviewing another patch that used this (assumes it is on) and dug deaper into 
this this code to review.

Do we ever not want to have it on?  Do you want to add end-to-end testing for 
the cases it is off?

> Remove hbase.regionsizecalculator.enable from RegionSizeCalculator
> ------------------------------------------------------------------
>
>                 Key: HBASE-12629
>                 URL: https://issues.apache.org/jira/browse/HBASE-12629
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: 
> 0001-HBASE-12629-Remove-hbase.regionsizecalculator.enable.patch
>
>
> The RegionSizeCalculator has a option to disable it.  It is on by default and 
> end-to-end use with it disabled is not tested or used anywhere except for a 
> simple unit test.  This removes it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to