[ 
https://issues.apache.org/jira/browse/HBASE-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251151#comment-14251151
 ] 

Enis Soztutar commented on HBASE-12629:
---------------------------------------

bq. 1) Just removing that rscalc config so we have one knob using the the 
HBASE-12590 deskew is used.
bq. 2) An alternative where we refactor instead of remove and have the 
HBASE-12590 patch decides on the to pick the 
"ClusterStatusRegionSizeCalculator" if enabled or "AlwaysZeroRSCalc" if not 
enabled. We'd combine HBASE-12590 and HBASE-10413's features into one config 
knob (instead of what currently would be two). If after some testing 
HBASE-12590 works nicely, I think I'd want it on by default as well.
I think it makes sense to combine the knobs. We do not need this particular 
config option per se, as long as we still have a way to disable it in case 
something goes wrong. 


> Remove hbase.regionsizecalculator.enable from RegionSizeCalculator
> ------------------------------------------------------------------
>
>                 Key: HBASE-12629
>                 URL: https://issues.apache.org/jira/browse/HBASE-12629
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 
> 0001-HBASE-12629-Remove-hbase.regionsizecalculator.enable.patch
>
>
> The RegionSizeCalculator has a option to disable it.  It is on by default and 
> end-to-end use with it disabled is not tested or used anywhere except for a 
> simple unit test.  This removes it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to