[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104372#comment-13104372
]
[email protected] commented on HBASE-4213:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1886
-----------------------------------------------------------
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
<https://reviews.apache.org/r/1786/#comment4372>
Master checks balanceSwitch at the beginning of balance(). Meaning, the
toggle of balanceSwitch would take effect in the next round of balancing.
We have two options in order to make balanceSwitch() call synchronous with
balance():
1. Change balanceSwitch() to be synchronous directly. This breaks the API
compatibility
2. Add new method, e.g. blockingBalanceSwitch(), to HMasterInterface()
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
<https://reviews.apache.org/r/1786/#comment4373>
From listChildrenAndWatchThem():
if (children == null) {
return null;
}
So I guess the answer is yes.
- Ted
On 2011-09-12 18:36:02, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1786/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-12 18:36:02)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. From Subbu:
bq. here is the latest patch that support alter_instant, an instant schema
change command that supports (Add, Modify, Delete column and Modify table)
actions through ZK.
bq.
bq. 1. This pattern capitalizes on the fact that HRI's are now in HDFS and
need not be sent over again from Master to RS cloud on every schema change
event.
bq.
bq. 2. Offers real time instant schema change as we bypass the explicit bulk
reassign (unassign + assign) of regions from master to RS.
bq.
bq. 3. Offers fault tolerant schema change support as schema changes now go
through ZK. Secondary master taking over a failed schema change will be
addressed through a separate JIRA.
bq.
bq.
bq. This addresses bug HBASE-4213.
bq. https://issues.apache.org/jira/browse/HBASE-4213
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522
bq. /src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522
bq. /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
1169522
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522
bq. /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522
bq. /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
1169522
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
1169522
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1169522
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
1169522
bq. /src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
PRE-CREATION
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
1169522
bq. /src/main/ruby/hbase/admin.rb 1169522
bq. /src/main/ruby/shell.rb 1169522
bq. /src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522
bq. /src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
1169522
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
PRE-CREATION
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
1169522
bq. /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
1169522
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
1169522
bq.
bq. Diff: https://reviews.apache.org/r/1786/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> Support for fault tolerant, instant schema updates with out master's
> intervention (i.e with out enable/disable and bulk assign/unassign) through
> ZK.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4213
> URL: https://issues.apache.org/jira/browse/HBASE-4213
> Project: HBase
> Issue Type: Improvement
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Fix For: 0.92.0
>
> Attachments: 4213-Instant_Schema_change_through_ZK.patch,
> 4213-V5-Support_instant_schema_changes_through_ZK.patch,
> 4213-V7-Support_instant_schema_changes_through_ZK.patch,
> 4213-V8-Support_instant_schema_changes_through_ZK.patch, 4213.v6,
> HBASE-4213-Instant_schema_change.patch,
> HBASE-4213_Instant_schema_change_-Version_2_.patch,
> HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
