[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107005#comment-13107005
]
[email protected] commented on HBASE-4213:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
-----------------------------------------------------------
(Updated 2011-09-17 03:16:42.534475)
Review request for hbase.
Changes
-------
bq. From Subbu:
In addition to most of the review comments, V9 adds:
1. Handle cases when the table is not in enabled state.
2. Ensures that concurrent alter requests are not missed.
3. Validate that alter can survive cases when one of the RS goes down during
alter, or multiple RS going down during alter or adding new RS servers to the
cloud during an alter.
4. Handle cases when primary master is brought down during alter and secondary
takes over.
5. Added new test cases for all of the above mentioned cases.
To-Do:
1. Revisit the load balancer toggling. It doesn't seem right.
2. Add monitoring support for alter process.
3. Gracefully handle cases when ZooKeeper throws exceptions during an alter.
4. Add fine grained tests to validate master failover cases.
5. Address any other comments/suggestions.
Summary
-------
bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change
command that supports (Add, Modify, Delete column and Modify table) actions
through ZK.
1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not
be sent over again from Master to RS cloud on every schema change event.
2. Offers real time instant schema change as we bypass the explicit bulk
reassign (unassign + assign) of regions from master to RS.
3. Offers fault tolerant schema change support as schema changes now go through
ZK. Secondary master taking over a failed schema change will be addressed
through a separate JIRA.
This addresses bug HBASE-4213.
https://issues.apache.org/jira/browse/HBASE-4213
Diffs (updated)
-----
/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1171786
/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
1171840
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1171786
/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
1171786
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
1171786
/src/main/resources/hbase-default.xml 1171786
/src/main/ruby/hbase/admin.rb 1171786
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
PRE-CREATION
/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1171786
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
1171786
Diff: https://reviews.apache.org/r/1786/diff
Testing
-------
Unit tests pass.
Thanks,
Ted
> Support for fault tolerant, instant schema updates with out master's
> intervention (i.e with out enable/disable and bulk assign/unassign) through
> ZK.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4213
> URL: https://issues.apache.org/jira/browse/HBASE-4213
> Project: HBase
> Issue Type: Improvement
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Fix For: 0.92.0
>
> Attachments: 4213-Instant_Schema_change_through_ZK.patch,
> 4213-V5-Support_instant_schema_changes_through_ZK.patch,
> 4213-V7-Support_instant_schema_changes_through_ZK.patch,
> 4213-V8-Support_instant_schema_changes_through_ZK.patch,
> 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
> 4213.v6, HBASE-4213-Instant_schema_change.patch,
> HBASE-4213_Instant_schema_change_-Version_2_.patch,
> HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
