[ 
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243714#comment-14243714
 ] 

stack commented on HBASE-10201:
-------------------------------

Yes. I think it is going to be ok. I missed the 'skip edits using seqid of each 
relating store' bit. My calc was region based.  Thanks for entertaining my 
question.  In my scenario, the first column family that had edit #1 should have 
a store seqid of -1 which would mean we'd not skip edit #1 when it came into 
replayRecoveredEditsIfAny,

I'm wondering how to make a unit test.  One thought was to stand up a single 
HRegion of multiple column families and populate it in various ways, out of 
balance, and then add a means of 'killing' the region.  Then create a 
'recoved.edits' file and reopen the region to verify edits are as expected (and 
do same for DLR replay scenario)?





 

> Port 'Make flush decisions per column family' to trunk
> ------------------------------------------------------
>
>                 Key: HBASE-10201
>                 URL: https://issues.apache.org/jira/browse/HBASE-10201
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Ted Yu
>            Assignee: zhangduo
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, 
> HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, 
> HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, 
> HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, 
> HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch, 
> HBASE-10201_16.patch, HBASE-10201_17.patch, HBASE-10201_18.patch, 
> HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, 
> HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, 
> HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, 
> memstore.png
>
>
> Currently the flush decision is made using the aggregate size of all column 
> families. When large and small column families co-exist, this causes many 
> small flushes of the smaller CF. We need to make per-CF flush decisions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to