[ 
https://issues.apache.org/jira/browse/HBASE-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247040#comment-14247040
 ] 

Vandana Ayyalasomayajula commented on HBASE-12686:
--------------------------------------------------

[~apurtell] The balancing is blocked as the daughter regions remain in 
transition forever. So if we make sure that after as failed split, the daughter 
regions are cleared from regions in transition, it must be good enough. But as 
a precaution, I will add a check that balance method returns true. 

{quote}
Any chance the daughters may no longer be in transition at this point?:
1322                      if 
(regionStates.isRegionInTransition(hri_a.getEncodedName())) {
1323                        regionOffline(hri_a);
1324                      }
1325                      if 
(regionStates.isRegionInTransition(hri_b.getEncodedName())) {
1326                        regionOffline(hri_b);
1327                      }
Just wondering why this change should not always offline the daughters.
{quote}
The daughters must be be transition state when a split operation fails. I am 
making sure the checks are tighter and making the daughter offline.

> Failures in split before PONR not clearing the daughter regions from regions 
> in transition during rollback
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12686
>                 URL: https://issues.apache.org/jira/browse/HBASE-12686
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 0.98.9
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Blocker
>             Fix For: 1.0.0, 0.98.9
>
>         Attachments: HBASE-12686-98.patch, HBASE-12686-branch-1.patch
>
>
> If there are any split failures then the both daughter regions left in 
> SPLITTING_NEW transition even after rollback, which will block balancing to 
> happen forever until unless master is restarted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to