[
https://issues.apache.org/jira/browse/HBASE-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259265#comment-14259265
]
Hadoop QA commented on HBASE-12746:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689203/12746-v2.patch
against master branch at commit 8426f1f53a5fecffe05bdd894779b08e23bbbfbf.
ATTACHMENT ID: 12689203
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12230//console
This message is automatically generated.
> [1.0.0RC0] Distributed Log Replay is on (HBASE-12577 was insufficient)
> ----------------------------------------------------------------------
>
> Key: HBASE-12746
> URL: https://issues.apache.org/jira/browse/HBASE-12746
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 1.0.0
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 12746-v2.patch, 12746.txt, 12746.txt
>
>
> Testing the 1.0.0RC0 candidate, I noticed DLR was on (because I was bumping
> into HBASE-12743) I thought it my environment but apparently not.
> If I add this to HMaster....
> diff --git
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> index a85c2e7..d745f94 100644
> --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> @@ -416,6 +416,10 @@ public class HMaster extends HRegionServer implements
> MasterServices, Server {
> throw new IOException("Failed to start redirecting jetty server", e);
> }
> masterInfoPort = connector.getPort();
> + boolean dlr =
> + conf.getBoolean(HConstants.DISTRIBUTED_LOG_REPLAY_KEY,
> + HConstants.DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG);
> + LOG.info("Distributed log replay=" + dlr);
> }
> It says DLR is on. HBASE-12577 was not enough it seems. The
> hbase-default.xml still has DLR as true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
