[
https://issues.apache.org/jira/browse/HBASE-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263594#comment-14263594
]
stack commented on HBASE-12746:
-------------------------------
Changed my mind. Fixing my messedup commit. Here is what I did (revert, then
reapply absent the extraneous HBASE-12763 stuff):
commit a32f485fecbcf7e1aa7159ac2fa9851c1bf1ae48
Author: stack <[email protected]>
Date: Sat Jan 3 11:03:30 2015 -0800
HBASE-12746 [1.0.0RC0] Distributed Log Replay is on (HBASE-12577 was
insufficient) (Jeffrey Zhong)
Reapply after fixing up an overcommit.
commit d5f63f122131a45b24b5e3839d4b59a578652b2d
Author: stack <[email protected]>
Date: Sat Jan 3 10:59:58 2015 -0800
Revert "HBASE-12746 [1.0.0RC0] Distributed Log Replay is on (HBASE-12577
was insufficient) (Jeffrey Zhong)"
Overcommitted. Reverting so can apply intended patch
This reverts commit 2df74fbd4a85de1e5325ba6ad8595f2081238e29.
> [1.0.0RC0] Distributed Log Replay is on (HBASE-12577 was insufficient)
> ----------------------------------------------------------------------
>
> Key: HBASE-12746
> URL: https://issues.apache.org/jira/browse/HBASE-12746
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 1.0.0
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 12746-v2.patch, 12746.txt, 12746.txt
>
>
> Testing the 1.0.0RC0 candidate, I noticed DLR was on (because I was bumping
> into HBASE-12743) I thought it my environment but apparently not.
> If I add this to HMaster....
> diff --git
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> index a85c2e7..d745f94 100644
> --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> @@ -416,6 +416,10 @@ public class HMaster extends HRegionServer implements
> MasterServices, Server {
> throw new IOException("Failed to start redirecting jetty server", e);
> }
> masterInfoPort = connector.getPort();
> + boolean dlr =
> + conf.getBoolean(HConstants.DISTRIBUTED_LOG_REPLAY_KEY,
> + HConstants.DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG);
> + LOG.info("Distributed log replay=" + dlr);
> }
> It says DLR is on. HBASE-12577 was not enough it seems. The
> hbase-default.xml still has DLR as true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
