[
https://issues.apache.org/jira/browse/HBASE-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259908#comment-14259908
]
Hadoop QA commented on HBASE-12762:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689278/HBASE-12762-trunk.patch
against master branch at commit fbdaf62bf837abd74eca8b13e8786051ed4df38a.
ATTACHMENT ID: 12689278
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12241//console
This message is automatically generated.
> Region with no hfiles will have the highest locality cost in
> LocalityCostFunction
> ---------------------------------------------------------------------------------
>
> Key: HBASE-12762
> URL: https://issues.apache.org/jira/browse/HBASE-12762
> Project: HBase
> Issue Type: Improvement
> Components: Balancer
> Affects Versions: 0.99.2
> Reporter: cuijianwei
> Assignee: cuijianwei
> Priority: Minor
> Attachments: HBASE-12762-trunk.patch
>
>
> The locality cost of region will be computed in LocalityCostFunction.cost as:
> {code}
> double cost() {
> ...
> int index = -1;
> for (int j = 0; j < regionLocations.length; j++) {
> if (regionLocations[j] >= 0 && regionLocations[j] == serverIndex) {
> index = j;
> break;
> }
> }
> if (index < 0) {
> cost += 1; // ==> region with no hfiles will have the highest cost
> } else {
> cost += (double) index / (double) regionLocations.length;
> }
> ...
> }
> {code}
> The region with no hfiles(such as empty region) will have the highest cost
> which represents the worst case that region located in the server with no
> locality for hfiles. However, this might be the best case because there are
> no hlogs for the region. Although the absolute cost value won't affect the
> balance process, will it be more reasonable to have zero cost for such
> regions? such as:
> {code}
> ...
> if (index < 0) {
> if (regionLocation.length > 0) { // ==> only consider regions with
> hfiles
> cost += 1;
> }
> } else {
> cost += (double) index / (double) regionLocations.length;
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
