[
https://issues.apache.org/jira/browse/HBASE-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265353#comment-14265353
]
Hadoop QA commented on HBASE-12802:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12690154/HBASE-12802B.patch
against master branch at commit 24bcebdeeb5c8025a1171fd73b5f38e666ae819b.
ATTACHMENT ID: 12690154
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 76 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12311//console
This message is automatically generated.
> Remove unnecessary Table.flushCommits()
> ---------------------------------------
>
> Key: HBASE-12802
> URL: https://issues.apache.org/jira/browse/HBASE-12802
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12802.patch, HBASE-12802B.patch
>
>
> It looks like there are a lot of places where flushCommits() are called on
> tables that do not have autoFlush turned on. That might be a legacy concern
> from pre-autoFlush days. HBASE-12728 will likely result in removing the
> flushCommits() method from Table. The patch for this issue should remove all
> unnecessary calls to flushCommit() to prepare for the full fix.
> flushCommits() are only necessary after a setAutoFlushTo(false) is called.
> Here's the relevant code from HTable.java:
> {code:title=HTable.java|borderStyle=solid}
> @Override
> public void put(final Put put)
> throws InterruptedIOException, RetriesExhaustedWithDetailsException {
> doPut(put);
> if (autoFlush) {
> flushCommits();
> }
> }
> /**
> * {@inheritDoc}
> */
> @Override
> public void put(final List<Put> puts)
> throws InterruptedIOException, RetriesExhaustedWithDetailsException {
> for (Put put : puts) {
> doPut(put);
> }
> if (autoFlush) {
> flushCommits();
> }
> }
> {code}
> Puts have implicit flushCommits() calls when autoFlush is true. Deletes are
> not affected by autoFlush() and are not directly impacted by flushCommits()
> since deletes are not added to the writeAysncBuffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
