[
https://issues.apache.org/jira/browse/HBASE-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265561#comment-14265561
]
Hudson commented on HBASE-12802:
--------------------------------
FAILURE: Integrated in HBase-1.1 #57 (See
[https://builds.apache.org/job/HBase-1.1/57/])
HBASE-12802 Remove unnecessary Table.flushCommits() (Solomon Duskis) (tedyu:
rev 0311cc860c91a11b4ad63eca06c4feb3f939f874)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFiltering.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestChangingEncoding.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
*
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java
* hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestOpenTableInCoprocessor.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java
> Remove unnecessary Table.flushCommits()
> ---------------------------------------
>
> Key: HBASE-12802
> URL: https://issues.apache.org/jira/browse/HBASE-12802
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Fix For: 1.0.0, 2.0.0, 1.1.0
>
> Attachments: 12802-1.0.patch, HBASE-12802.patch, HBASE-12802B.patch
>
>
> It looks like there are a lot of places where flushCommits() are called on
> tables that do not have autoFlush turned on. That might be a legacy concern
> from pre-autoFlush days. HBASE-12728 will likely result in removing the
> flushCommits() method from Table. The patch for this issue should remove all
> unnecessary calls to flushCommit() to prepare for the full fix.
> flushCommits() are only necessary after a setAutoFlushTo(false) is called.
> Here's the relevant code from HTable.java:
> {code:title=HTable.java|borderStyle=solid}
> @Override
> public void put(final Put put)
> throws InterruptedIOException, RetriesExhaustedWithDetailsException {
> doPut(put);
> if (autoFlush) {
> flushCommits();
> }
> }
> /**
> * {@inheritDoc}
> */
> @Override
> public void put(final List<Put> puts)
> throws InterruptedIOException, RetriesExhaustedWithDetailsException {
> for (Put put : puts) {
> doPut(put);
> }
> if (autoFlush) {
> flushCommits();
> }
> }
> {code}
> Puts have implicit flushCommits() calls when autoFlush is true. Deletes are
> not affected by autoFlush() and are not directly impacted by flushCommits()
> since deletes are not added to the writeAysncBuffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
