[
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266133#comment-14266133
]
Sean Busbey commented on HBASE-11677:
-------------------------------------
Patch looks good, thanks for the effort [~Usha710]. Some feedback
{code}
diff --git a/hbase-server/src/test/resources/log4j.properties
b/hbase-server/src/test/resources/log4j.properties
index 6ee91ef..add4193 100644
--- a/hbase-server/src/test/resources/log4j.properties
+++ b/hbase-server/src/test/resources/log4j.properties
@@ -57,6 +57,11 @@ log4j.appender.console.layout.ConversionPattern=%d{ISO8601}
%-5p [%t] %C{2}(%L):
log4j.logger.org.apache.hadoop=WARN
log4j.logger.org.apache.zookeeper=ERROR
log4j.logger.org.apache.hadoop.hbase=DEBUG
+log4j.logger.org.apache.hadoop.hbase.client.ScannerCallable=ALL
+log4j.logger.org.apache.hadoop.hbase.client.RpcRetryingCallerImpl=ALL
+log4j.logger.org.apache.hadoop.hbase.ipc.RpcServer=ALL
+log4j.logger.org.apache.hadoop.hbase.AbstractRpcClient=ALL
+log4j.logger.org.apache.hadoop.hbase.fs.HFileSystem=ALL
{code}
Please leave these commented out with a note that they should be uncommented if
folks need more detail (ideally with the name of the test that set them in the
first place)
----
We'll have to do a deprecation cycle on changing the following from
public/protected to private because they're marked InterfaceAudience.Public.
For now, you should just mark them @deprecated in master. If we get the change
into the next 1.0 RC, then we can change them in master as a follow on.
* ImportTsv
* hbase.mapreduce.TableSplit
* CodecPerformance
> Make Logger instance modifiers consistent
> -----------------------------------------
>
> Key: HBASE-11677
> URL: https://issues.apache.org/jira/browse/HBASE-11677
> Project: HBase
> Issue Type: Task
> Reporter: Sean Busbey
> Priority: Minor
> Labels: beginner, sonar
> Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch,
> HBASE-11677.patch
>
>
> We have some instances of Logger that are missing one of being private,
> static, and final.
> ex from HealthChecker.java, missing final
> {code}
> private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment
> for the commonly used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
