[
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277801#comment-14277801
]
Sean Busbey commented on HBASE-11677:
-------------------------------------
+1. patch looks good. I'll push to master shortly unless someone has an
objection.
I'm not sure it's worth the pain of pulling back to 1.x if we aren't going to
get a full deprecation cycle. [~enis], opinion on me pushing this back to
branch-1.0 so we can remove the deprecated bits in master?
> Make Logger instance modifiers consistent
> -----------------------------------------
>
> Key: HBASE-11677
> URL: https://issues.apache.org/jira/browse/HBASE-11677
> Project: HBase
> Issue Type: Task
> Reporter: Sean Busbey
> Priority: Minor
> Labels: beginner, sonar
> Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch,
> HBASE-11677-v3.patch, HBASE-11677.patch
>
>
> We have some instances of Logger that are missing one of being private,
> static, and final.
> ex from HealthChecker.java, missing final
> {code}
> private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment
> for the commonly used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
