[
https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296072#comment-14296072
]
Enis Soztutar commented on HBASE-12867:
---------------------------------------
Kevin the patch is great.
bq. Through this process found that the ReplicationPeerConfig methods in
ReplicationAdmin are not all exposed through the hbase shell or through
replication_admin.rb. This makes testing for add_peer hard because its
impossible to get back details about the peer without access to listPeerConfigs
and getPeerConfig in replication_admin.rb. Should there be a new JIRA opened to
address this?
We can do it here or in a follow up issue. Both are ok.
In the patch why did you have a test that is commented out?
{code}
+ # assert_raise fails on native exceptions -
https://jira.codehaus.org/browse/JRUBY-5279
{code}
One last thing is that, regular commands like create table, etc define
constants used in hbase-shell/src/main/ruby/hbase.rb. so that the user does not
have to do {{:CONSTANT}}, and instead can do {{CONSTANT}}. We can do the same
thing for consistency with the other commands.
> Shell does not support custom replication endpoint specification
> ----------------------------------------------------------------
>
> Key: HBASE-12867
> URL: https://issues.apache.org/jira/browse/HBASE-12867
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: Kevin Risden
> Labels: beginner, beginners
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
> Attachments: HBASE-12867-v1.patch, HBASE-12867-v2.patch,
> HBASE-12867.patch
>
>
> On HBASE-12254 and also at
> https://github.com/risdenk/hbase-custom-replication-endpoint-example
> [~risdenk] made the following observations and suggestions regarding custom
> replication endpoints that I think are a reasonable blueprint for improvement:
> {quote}
> I was trying out the pluggable replication endpoint feature and found the
> following:
> - you must use the ReplicationAdmin to add the new ReplicationEndpoint
> - hbase shell add_peer command doesn't support specifying a custom class
> - hbase shell add_peer relies on the newly deprecated ReplicationAdmin
> addPeer methods
> - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends
> Collection<String>> instead of a string
> {quote}
> We should fix the add_peer command in the shell at least.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
