[
https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293841#comment-14293841
]
Kevin Risden commented on HBASE-12867:
--------------------------------------
Added HBASE-12867-v1.patch which addresses the comments by [~enis].
The backwards compatibility is still there and makes use of some rubyism for it
to work. The documentation for the command was updated with the only real
change from the comments above being that arguments must be preceded by a colon
(ie: :ENDPOINT_CLASSNAME or :TABLE_CFS).
There probably should be tests for this but didn't see tests for the other
shell commands. I can look into that later this week.
> Shell does not support custom replication endpoint specification
> ----------------------------------------------------------------
>
> Key: HBASE-12867
> URL: https://issues.apache.org/jira/browse/HBASE-12867
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: Kevin Risden
> Labels: beginner, beginners
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
> Attachments: HBASE-12867-v1.patch, HBASE-12867.patch
>
>
> On HBASE-12254 and also at
> https://github.com/risdenk/hbase-custom-replication-endpoint-example
> [~risdenk] made the following observations and suggestions regarding custom
> replication endpoints that I think are a reasonable blueprint for improvement:
> {quote}
> I was trying out the pluggable replication endpoint feature and found the
> following:
> - you must use the ReplicationAdmin to add the new ReplicationEndpoint
> - hbase shell add_peer command doesn't support specifying a custom class
> - hbase shell add_peer relies on the newly deprecated ReplicationAdmin
> addPeer methods
> - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends
> Collection<String>> instead of a string
> {quote}
> We should fix the add_peer command in the shell at least.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
