[
https://issues.apache.org/jira/browse/HBASE-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297786#comment-14297786
]
Stephen Yuan Jiang commented on HBASE-12070:
--------------------------------------------
Because Jenkins only run the patch from master, I run the check locally:
The javadoc warnings are existing. Not newly introduced.
{noformat}
{color:red}-1 overall{color}.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version ) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{noformat}
Running all test via "mvn test -PrunAllTests" in my Mac. Almost all tests
passed. I have 1-2 random test failures in each run (re-run the failed test
individually or in eclipse, they passed; or even run the entire test again,
they would pass - it is likely my local machine issue, the error usually is "IO
Waiting for startup of standalone..."; or in
org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite, it failed sometimes; my code
would not be executed by this test).
> Add an option to hbck to fix ZK inconsistencies
> -----------------------------------------------
>
> Key: HBASE-12070
> URL: https://issues.apache.org/jira/browse/HBASE-12070
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Affects Versions: 1.1.0
> Reporter: Sudarshan Kadambi
> Assignee: Stephen Yuan Jiang
> Fix For: 1.1.0
>
> Attachments: HBASE-12070.v1-branch-1.patch
>
>
> If the HMaster bounces in the middle of table creation, we could be left in a
> state where a znode exists for the table, but that hasn't percolated into
> META or to HDFS. We've run into this a couple times on our clusters. Once the
> table is in this state, the only fix is to rm the znode using the
> zookeeper-client. Doing this manually looks a bit error prone. Could an
> option be added to hbck to catch and fix such inconsistencies?
> A more general issue I'd like comment on is whether it makes sense for
> HMaster to be maintaining its own write-ahead log? The idea would be that on
> a bounce, the master would discover it was in the middle of creating a table
> and either rollback or complete that operation? An issue that we observed
> recently was that a table that was in DISABLING state before a bounce was not
> in that state after. A write-ahead log to persist table state changes seems
> useful. Now, all of this state could be in ZK instead of the WAL - it doesn't
> matter where it gets persisted as long as it does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
