[
https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-13030:
--------------------------
Attachment: 13030v2.txt
Thanks for reviews lads.
@enis It can't be in ResultScanner since AbstractClientScanner is subclass of
ResultScanner but I hear you. I cut down my original patch removing Scan
messing. You have to do more acrobatics to get scanner metrics but that is ok I
think. It is advanced usage. Advantage of this patch though is that the
acrobatics are less than what is being done over in ScannerPE and what Lars has
to do in his example code (i.e. using private ProtobufUtil) and it is
documented a little (it is ugly using Abstract class casting). We can clean
further post 1.0.0 is my thinking? But maybe you have better idea. Thanks.
> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get,
> Delete, etc., addColumn
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-13030
> URL: https://issues.apache.org/jira/browse/HBASE-13030
> Project: HBase
> Issue Type: Bug
> Components: Operability
> Affects Versions: 1.0.0
> Reporter: stack
> Assignee: stack
> Fix For: 1.0.0, 2.0.0, 1.1.0
>
> Attachments: 13030.txt, 13030v2.txt
>
>
> These are some of the items raised by [~larsgeorge] looking at our API for
> first time in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it
> is IA.private and to get at it from Scan context, you need to use private
> ProtobufUtils. This seems like useful advanced user utility that should not
> be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly
> but didn't want to do anything more adventurous this late in the game).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
