[ 
https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-13030:
--------------------------
    Attachment: 13030v7.txt

Ok.

Making the getScanMetrics available on ResultScanner is not going to make 
anyone happy. The POJO is for internal use cleared at key transition points 
with the accumulated stats added to the running PB object serialized in Scan.

So, back to patch #1 where we enable and get scan metrics from the Scan object 
itself. Anything else will just piss off [~larsgeorge] and anyone else who'd 
try to do ScanMetrics.

This should be it [~enis]


> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, 
> Delete, etc., addColumn
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13030
>                 URL: https://issues.apache.org/jira/browse/HBASE-13030
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 1.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>
>         Attachments: 13030.txt, 13030v2.txt, 13030v3.txt, 13030v5.txt, 
> 13030v7.txt, hbase-13030-scanmetrics.patch, hbase-13030-v6.patch
>
>
> These are some of the items raised by [~larsgeorge] looking at our API for 
> first time in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it 
> is IA.private and to get at it from Scan context, you need to use private 
> ProtobufUtils. This seems like useful advanced user utility that should not 
> be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly 
> but didn't want to do anything more adventurous this late in the game).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to