[
https://issues.apache.org/jira/browse/HBASE-11842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324438#comment-14324438
]
Ted Yu commented on HBASE-11842:
--------------------------------
Looks good overall.
In the usage example of IntegrationTestRegionReplicaReplication :
{code}
61 * -DIntegrationTestRegionReplicaReplication.num_keys_per_server=10000
62 * -Dhbase.IntegrationTestRegionReplicaReplication.runtime=600000
{code}
Second line above has 'hbase.' prefix. Should it be consistent with the style
of the other options ?
{code}
176 while (System.currentTimeMillis() - start < 0.9 * runtime) {
{code}
Why factor of 0.9 is used above ?
{code}
377 // entry is not coming form the primary region, filter it out.
{code}
coming form -> coming from
{code}
32 public class ConstantDelayQueue<E> implements BlockingQueue<E> {
{code}
Please add audience annotation for ConstantDelayQueue.
{code}
39 this.end = System.currentTimeMillis() + delayMs;
{code}
Please use EnvironmentEdgeManager.
> Integration test for async wal replication to secondary regions
> ---------------------------------------------------------------
>
> Key: HBASE-11842
> URL: https://issues.apache.org/jira/browse/HBASE-11842
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.1.0
>
> Attachments: hbase-11842_v1.patch
>
>
> We should add an integration test to cover async wal replication to secondary
> regions.
> Async wal replication to region replicas has been committed (HBASE-11568) and
> flush /compaction handling (HBASE-11569) and failover handling for secondary
> region replicas (HBASE-11580) is in the works.
> The test can use LoadTestTool over a table with region replicas. We can write
> to the primary regions, and read from the secondary region replicas in reader
> threads to do the verification.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
