[
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342677#comment-14342677
]
Hari Krishna Dara commented on HBASE-13014:
-------------------------------------------
+1 for using a proper review tool, it is too painful to have to copy paste the
code snippets here.
A quick look at the 2nd patch shows more {{close()}} calls outside finally
blocks. I see {{stripServer()}} is still the same, I recommend simplifying it
for the sake of better understanding and maintainability. There are others that
haven't changed like {{new String()}}. It is getting difficult to track which
review comments have been incorporated and which haven't been.
> Java Tool For Region Moving
> ----------------------------
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
> Issue Type: Improvement
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Attachments: HBASE-13014-v2.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of
> region_mover.rb into a Java tool and use region_mover.rb only only as a
> wrapper around it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
