[jira] [Commented] (HBASE-13014) Java Tool For Region Moving

[Abhishek Singh Chouhan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343042#comment-14343042
 ] 

Abhishek Singh Chouhan commented on HBASE-13014:
------------------------------------------------

Thanks for the review.
I've incorporated most of the comments.

 private String stripServer(ArrayList<String> regionServers, String hostname, 
int port)
      throws Exception {
    String server = hostname+ServerName.SERVERNAME_SEPARATOR+port;
    if (! regionServers.remove(server)) {
      throw new Exception("Server: " + server + " is not Online");
    }
    return regionServers;
  }

won't work as each regionServer in ArrayList<String> regionServers has 
hostname,port and startcode hence comparing only the first two (host and 
port).Have closed all file handlers in the finally blocks and otherwise the 
tool will exit with proper exceptions in case any (admin and others)close 
operation fails.

> Java Tool For Region Moving 
> ----------------------------
>
>                 Key: HBASE-13014
>                 URL: https://issues.apache.org/jira/browse/HBASE-13014
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>         Attachments: HBASE-13014-v2.patch, HBASE-13014-v3.patch, 
> HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of 
> region_mover.rb into a Java tool and use region_mover.rb only only as a 
> wrapper around it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)