[
https://issues.apache.org/jira/browse/HBASE-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351340#comment-14351340
]
Hadoop QA commented on HBASE-13121:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12703181/hbase-13121_v2.patch
against master branch at commit 5845f72ad60a7a7f5a04c01b68d841c78c38f79a.
ATTACHMENT ID: 12703181
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13124//console
This message is automatically generated.
> Async wal replication for region replicas and dist log replay does not work
> together
> ------------------------------------------------------------------------------------
>
> Key: HBASE-13121
> URL: https://issues.apache.org/jira/browse/HBASE-13121
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.1.0
>
> Attachments: hbase-13121_v1.patch, hbase-13121_v2.patch
>
>
> We had not tested dist log replay while testing async wal replication for
> region replicas. There seems to be a couple of issues, but fixable.
> The distinction for dist log replay is that, the region will be opened for
> recovery and regular writes when a primary fails over. This causes the region
> open event marker to be written to WAL, but at this time, the region actually
> does not contain all the edits flushed (since it is still recovering). If
> secondary regions see this event, and picks up all the files in the region
> open event marker, then they can drop edits.
> The solution is:
> - Only write the region open event marker to WAL when region is out of
> recovering mode.
> - Force a flush out of recovering mode. This ensures that all data is force
> flushed in this case. Before the region open event marker is written, we
> guarantee that all data in the region is flushed, so the list of files in the
> event marker is complete.
> - Edits coming from recovery are re-written to WAL when recovery is in
> action. These edits will have a larger seqId then their "original" seqId. If
> this is the case, we do not replicate these edits to the secondary replicas.
> Since the dist log replay recovers edits out of order (coming from parallel
> replays from WAL file split tasks), this ensures that TIMELINE consistency is
> respected and edits are not seen out of order in secondaries. These edits are
> seen from secondaries via the forced flush event.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
