[ 
https://issues.apache.org/jira/browse/HBASE-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361995#comment-14361995
 ] 

Srikanth Srungarapu commented on HBASE-13241:
---------------------------------------------

A few concerns:
* Shouldn't be we use TEST_TABLE.getNameSpaceAsString()?
{code}
+    assertEquals(0, AccessControlLists.getNamespacePermissions(conf, 
TEST_TABLE.getNameAsString())
+        .size());
{code}
* It would be better if we can also check that scan fails for unauthorized 
users.
* Couldn't understand why this should pass for USER1_TESTGROUP_TABLE? Are we 
giving this user any special perms during set up? May be, I'm missing something 
here.
{code}
+    verifyAllowed(grantActionAtTableLevel, SUPERUSER, USER1_TESTGROUP_TABLE, 
USER2_TESTGROUP_TABLE);
{code}

> Add tests for group level grants
> --------------------------------
>
>                 Key: HBASE-13241
>                 URL: https://issues.apache.org/jira/browse/HBASE-13241
>             Project: HBase
>          Issue Type: Improvement
>          Components: security, test
>            Reporter: Sean Busbey
>            Assignee: Ashish Singhi
>            Priority: Critical
>         Attachments: HBASE-13241-v1.patch, HBASE-13241.patch
>
>
> We need to have tests for group-level grants for various scopes. ref: 
> HBASE-13239



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to