[
https://issues.apache.org/jira/browse/HBASE-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362002#comment-14362002
]
Ashish Singhi commented on HBASE-13241:
---------------------------------------
Thanks Srikanth for the comments.
bq. Shouldn't be we use TEST_TABLE.getNameSpaceAsString()?
Typical copy paste error, copied it from TestAccesController class. Will
correct at both the places.
bq. It would be better if we can also check that scan fails for unauthorized
users.
Will address in the next patch.
bq. Couldn't understand why this should pass for USER1_TESTGROUP_TABLE? Are we
giving this user any special perms during set up? May be, I'm missing something
here.
USER1_TESTGROUP_TABLE belongs to TESTGROUP_TABLE group
{noformat}
+ USER1_TESTGROUP_TABLE =
+ User.createUserForTesting(conf, "test_table1", new String[] {
TESTGROUP_TABLE });
{noformat}
and we are granting required (ADMIN and READ) permsissions to it in
{{testGrantAtTableLevel}} method. Hence it passes.
{noformat}
+ ProtobufUtil.grant(protocol, '@' + TESTGROUP_TABLE, TEST_TABLE,
null, null, Action.ADMIN,
+ Action.READ);
{noformat}
> Add tests for group level grants
> --------------------------------
>
> Key: HBASE-13241
> URL: https://issues.apache.org/jira/browse/HBASE-13241
> Project: HBase
> Issue Type: Improvement
> Components: security, test
> Reporter: Sean Busbey
> Assignee: Ashish Singhi
> Priority: Critical
> Attachments: HBASE-13241-v1.patch, HBASE-13241.patch
>
>
> We need to have tests for group-level grants for various scopes. ref:
> HBASE-13239
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
