[ 
https://issues.apache.org/jira/browse/HBASE-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365617#comment-14365617
 ] 

Nick Dimiduk commented on HBASE-13265:
--------------------------------------

{noformat}
 union TMutation {
-  1: optional TPut put,
-  2: optional TDelete deleteSingle,
+  1: TPut put,
+  2: TDelete deleteSingle,
 }
{noformat}

Is {{optional}} the default specifier?

All these field name changes are to line up the IDL with the code, of will this 
require structural changes in the code as well? Including example build errors 
would give the rest of us context.

+1 if this works for you Elliott.

[~larsgeorge], [~octo47] want to have a look?

> Make thrift2 usable from c++
> ----------------------------
>
>                 Key: HBASE-13265
>                 URL: https://issues.apache.org/jira/browse/HBASE-13265
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-13265.patch
>
>
> Currently the c++ code generated from our thrift2 idl doesn't compile. Mostly 
> this is a naming issue for parameters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to