[ 
https://issues.apache.org/jira/browse/HBASE-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365646#comment-14365646
 ] 

Elliott Clark commented on HBASE-13265:
---------------------------------------

bq.Is optional the default specifier?
For unions one is required and the rest can't be there. So optional is kind of 
implied and kind wrong at the same time. Most versions of thrift this works 
just fine. On an internal build with a very recent version of thrift this 
breaks.

bq.All these field name changes are to line up the IDL with the code, of will 
this require structural changes in the code as well? Including example build 
errors would give the rest of us context.
There should be no code changes required since the parameters stayed the same. 
This should only change the generated code.  Let my try and get the error from 
the internal customer who initially reported the issue.

> Make thrift2 usable from c++
> ----------------------------
>
>                 Key: HBASE-13265
>                 URL: https://issues.apache.org/jira/browse/HBASE-13265
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-13265.patch
>
>
> Currently the c++ code generated from our thrift2 idl doesn't compile. Mostly 
> this is a naming issue for parameters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to