[
https://issues.apache.org/jira/browse/HBASE-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367274#comment-14367274
]
Matteo Bertozzi commented on HBASE-13241:
-----------------------------------------
ok, let's look at it in a different way.
when you look at the other tests written with verifyAllowed()/verifyDenied() it
is clear what the behavior is without even looking at the action implementation.
when you have everything in a single block like the
USER1_TESTGROUP_QUALIFIER.runAs(), you have to look at the code and figure out
what is doing. and then there is the question, why are we testing for denied
just for a single user? what about the others..
yes, it may result in more code, because you have to break down in more
actions. but in my opinion it is easier to read and extend. also for someone
that want to add a new test is easier to decide what to do, if every test is
using verifyAllowed/denied I should do that too.
> Add tests for group level grants
> --------------------------------
>
> Key: HBASE-13241
> URL: https://issues.apache.org/jira/browse/HBASE-13241
> Project: HBase
> Issue Type: Improvement
> Components: security, test
> Reporter: Sean Busbey
> Assignee: Ashish Singhi
> Priority: Critical
> Attachments: HBASE-13241-v1.patch, HBASE-13241-v2.patch,
> HBASE-13241-v3.patch, HBASE-13241-v4.patch, HBASE-13241-v5.patch,
> HBASE-13241.patch
>
>
> We need to have tests for group-level grants for various scopes. ref:
> HBASE-13239
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
