[ 
https://issues.apache.org/jira/browse/HBASE-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368792#comment-14368792
 ] 

Matteo Bertozzi commented on HBASE-13241:
-----------------------------------------

a couple of things:

replace waitTableEnabled() with waitUntilAllRegionsAssigned()

since you have multiple and different actions/checks grouped in a single test. 
add a message to the assert. assert(msg, cond), at least it will be easy to 
identify what may be the problem without looking at the code. otherwise the 
failure will look like this
{noformat}
java.lang.AssertionError: null
        at org.junit.Assert.fail(Assert.java:86)
        at 
org.apache.hadoop.hbase.security.access.TestAccessController2$7.run(TestAccessController2.java:362)
        at 
org.apache.hadoop.hbase.security.access.TestAccessController2$7.run(TestAccessController2.java:354)
        ...
        at 
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:160)
        at 
org.apache.hadoop.hbase.security.access.TestAccessController2.testPostGrantAndRevokeScanAction(TestAccessController2.java:424)
{noformat}

> Add tests for group level grants
> --------------------------------
>
>                 Key: HBASE-13241
>                 URL: https://issues.apache.org/jira/browse/HBASE-13241
>             Project: HBase
>          Issue Type: Improvement
>          Components: security, test
>            Reporter: Sean Busbey
>            Assignee: Ashish Singhi
>            Priority: Critical
>         Attachments: HBASE-13241-v1.patch, HBASE-13241-v2.patch, 
> HBASE-13241-v3.patch, HBASE-13241-v4.patch, HBASE-13241-v5.patch, 
> HBASE-13241-v6.patch, HBASE-13241.patch
>
>
> We need to have tests for group-level grants for various scopes. ref: 
> HBASE-13239



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to