[
https://issues.apache.org/jira/browse/HBASE-11544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378696#comment-14378696
]
stack commented on HBASE-11544:
-------------------------------
bq. Can we amend this with backwards compatible changes regarding RegionScanner?
Chatting we thought nextRaw would actually return ScannerContext -- the above
suggestion is a little off here (NextState is actually purged).
Please sketch a non-breaking change [~apurtell] and we'll take a looksee. The
ScannerContext instance per rpc session will do what NextState did but
[~jonathan.lawlor] will also use it in subsequent patches to carry timings for
the heartbeating feature (he has a *plan*!)
Adding ScannerContext as a param will be breaking change. You are suggesting
somehow we'd have override to take ScannerContext?
Can revert. Would like to see what non-breaking looks like first (and why
wouldn't Phoenix want to make use of these amazing newness anyways? Ain't
Region Interface coming in in 1.1.0 too so its going to have some work to do
anyways?
> [Ergonomics] hbase.client.scanner.caching is dogged and will try to return
> batch even if it means OOME
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-11544
> URL: https://issues.apache.org/jira/browse/HBASE-11544
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Lawlor
> Priority: Critical
> Fix For: 2.0.0, 1.1.0
>
> Attachments: Allocation_Hot_Spots.html,
> HBASE-11544-branch_1_0-v1.patch, HBASE-11544-branch_1_0-v2.patch,
> HBASE-11544-v1.patch, HBASE-11544-v2.patch, HBASE-11544-v3.patch,
> HBASE-11544-v4.patch, HBASE-11544-v5.patch, HBASE-11544-v6.patch,
> HBASE-11544-v6.patch, HBASE-11544-v6.patch, HBASE-11544-v7.patch,
> HBASE-11544-v8-branch-1.patch, HBASE-11544-v8.patch, gc.j.png, h.png,
> hits.j.png, m.png, mean.png, net.j.png, q (2).png
>
>
> Running some tests, I set hbase.client.scanner.caching=1000. Dataset has
> large cells. I kept OOME'ing.
> Serverside, we should measure how much we've accumulated and return to the
> client whatever we've gathered once we pass out a certain size threshold
> rather than keep accumulating till we OOME.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
