[
https://issues.apache.org/jira/browse/HBASE-11544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378740#comment-14378740
]
Enis Soztutar commented on HBASE-11544:
---------------------------------------
bq. Would like to see what non-breaking looks like first (and why wouldn't
Phoenix want to make use of these amazing newness anyways? Ain't Region
Interface coming in in 1.1.0 too so its going to have some work to do anyways?
The patch at PHOENIX-1763 already contains some fixes on top of changes
related to this patch. I think I can do the necessary changes after the
addendum lands if the mapping is clear. If we have the ScannerContext, even the
results should go in there, no?
bq. and why wouldn't Phoenix want to make use of these amazing newness anyways?
Phoenix right now does not make use of limit (in some cases) and
remainingResultSize. Some of the Phoenix's scanners are transforming the data
completely (group by aggregate scanner) which drives the underlying scan, and
buffers in memory (with optional spill), but ignores remainingResultSize
because it is not incorporated yet. It should be doable, but will require some
work.
> [Ergonomics] hbase.client.scanner.caching is dogged and will try to return
> batch even if it means OOME
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-11544
> URL: https://issues.apache.org/jira/browse/HBASE-11544
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Lawlor
> Priority: Critical
> Fix For: 2.0.0, 1.1.0
>
> Attachments: Allocation_Hot_Spots.html,
> HBASE-11544-branch_1_0-v1.patch, HBASE-11544-branch_1_0-v2.patch,
> HBASE-11544-v1.patch, HBASE-11544-v2.patch, HBASE-11544-v3.patch,
> HBASE-11544-v4.patch, HBASE-11544-v5.patch, HBASE-11544-v6.patch,
> HBASE-11544-v6.patch, HBASE-11544-v6.patch, HBASE-11544-v7.patch,
> HBASE-11544-v8-branch-1.patch, HBASE-11544-v8.patch, gc.j.png, h.png,
> hits.j.png, m.png, mean.png, net.j.png, q (2).png
>
>
> Running some tests, I set hbase.client.scanner.caching=1000. Dataset has
> large cells. I kept OOME'ing.
> Serverside, we should measure how much we've accumulated and return to the
> client whatever we've gathered once we pass out a certain size threshold
> rather than keep accumulating till we OOME.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
