[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380953#comment-14380953
]
Josh Elser commented on HBASE-13262:
------------------------------------
Cool, thanks for taking a look.
{quote}
Nit: The methods for checking moreResultsInRegion were placed inside the
RegionServerCallable. I wonder if they would be better located inside
ScannerCallable rather than overridden there. The flag is only really relevant
when we're scanning, so seems weird that we have it inside
RegionServerCallable. That being said, I do understand you were looking to
match behavior of getHRegionInfo so probably why it is in RegionServerCallable
{quote}
Yeah, that's right. I can lift it up to ScannerCallable if you think that makes
more sense. Like you said, I was just trying to mimic what was already in place.
{quote}
It seems as though the logic within ClientScanner will deal with this problem
well. I think the only part left would be to expand that coverage into the
ClientSmallScanner and ClientSmallReversed scanners and then backport it to
0.98 and branch-1.0 (I know above you mentioned your intention was to get
ClientScanner covered first before worrying about the others).
{quote}
I've been going under the assumption that it's much less likely to run into
them (emphasis on "small"). For the sake of getting this out, I didn't want to
make yet another change as we get close, but thought I would just update those
as a follow-on (hopefully with some more tests). Really doesn't matter if we
just do it at once.
> ResultScanner doesn't return all rows in Scan
> ---------------------------------------------
>
> Key: HBASE-13262
> URL: https://issues.apache.org/jira/browse/HBASE-13262
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 2.0.0, 1.1.0
> Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: 2.0.0, 1.1.0, 0.98.13
>
> Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
> HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch,
> HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch,
> HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch,
> regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt
>
>
> Tried to write a simple Java client again 1.1.0-SNAPSHOT.
> * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]),
> for a total of 10M cells written
> * Read back the data from the table, ensure I saw 10M cells
> Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of
> the actual rows. Running against 1.0.0, returns all 10M records as expected.
> [Code I was
> running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
> for the curious.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
