[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382251#comment-14382251
 ] 

Lars Hofhansl commented on HBASE-13262:
---------------------------------------

Looks good to me.
{{+      if (null != values && values.length > 0 && 
callable.getServerHasMoreResultsContext()) {}}

I'd probably name this just {{callable.hasMoreResultsContext}}. So that will 
work right with an old client, right? It'll just not read the context and fall 
back to the old logic. That's what the code does, just making sure it's 
something we tested.


> ResultScanner doesn't return all rows in Scan
> ---------------------------------------------
>
>                 Key: HBASE-13262
>                 URL: https://issues.apache.org/jira/browse/HBASE-13262
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0, 1.1.0
>         Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 2.0.0, 1.1.0, 0.98.13
>
>         Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
> HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
> HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
> HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
> HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
> testrun_branch1.0.txt
>
>
> Tried to write a simple Java client again 1.1.0-SNAPSHOT.
> * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
> for a total of 10M cells written
> * Read back the data from the table, ensure I saw 10M cells
> Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
> the actual rows. Running against 1.0.0, returns all 10M records as expected.
> [Code I was 
> running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
>  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to