[
https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117456#comment-13117456
]
jirapos...@reviews.apache.org commented on HBASE-4422:
------------------------------------------------------
bq. On 2011-09-29 00:50:58, Andrew Purtell wrote:
bq. >
/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java, line
112
bq. > <https://reviews.apache.org/r/2089/diff/1/?file=46305#file46305line112>
bq. >
bq. > CacheConfig could extend Configuration? It's only extra constants
and constructors, really.
I considered doing that. But they seem orthogonal in most of their usage and I
think it'd be weird to pass our Configuration all the way down into HFile
reading and such. Changing config values dynamically (like disabling caching
for a specific read) would then require changing the base Configuration or
would the local booleans in the CacheConfig not match what's in the underlying
Configuration?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2089/#review2145
-----------------------------------------------------------
On 2011-09-28 19:56:14, Jonathan Gray wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2089/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-28 19:56:14)
bq.
bq.
bq. Review request for hbase, Dhruba Borthakur, Michael Stack, and Li Pi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Creates a new CacheConfig class and moves almost everything block cache
related into this single class. Adding new configuration params and booleans
and such should be much better.
bq.
bq. All tests are NOT passing yet, still working on it, but wanted to have
something up today. Basically "code complete" but broken :)
bq.
bq.
bq. This addresses bug HBASE-4422.
bq. https://issues.apache.org/jira/browse/HBASE-4422
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
1177030
bq.
/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1177030
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1177030
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java
1177030
bq. /src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1177030
bq. /src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java 1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java 1177030
bq.
/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
1177030
bq. /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
1177030
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
1177030
bq.
bq. Diff: https://reviews.apache.org/r/2089/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Still working through some tests that aren't passing.
bq.
bq.
bq. Thanks,
bq.
bq. Jonathan
bq.
bq.
> Move block cache parameters and references into single CacheConf class
> ----------------------------------------------------------------------
>
> Key: HBASE-4422
> URL: https://issues.apache.org/jira/browse/HBASE-4422
> Project: HBase
> Issue Type: Improvement
> Components: io
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.92.0
>
>
> From StoreFile down to HFile, we currently use a boolean argument for each of
> the various block cache configuration parameters that exist. The number of
> parameters is going to continue to increase as we look at compressed cache,
> delta encoding, and more specific L1/L2 configuration. Every new config
> currently requires changing many constructors because it introduces a new
> boolean.
> We should move everything into a single class so that modifications are much
> less disruptive.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
