[
https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117801#comment-13117801
]
jirapos...@reviews.apache.org commented on HBASE-4422:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2089/
-----------------------------------------------------------
(Updated 2011-09-30 01:05:40.429350)
Review request for hbase, Dhruba Borthakur, Michael Stack, and Li Pi.
Changes
-------
Fixed bugs mentioned by Lars and a few others. Lots of tests are passing
(TestCacheOnWrite for example). Running test suite now. Also added a small
test in TestBlocksRead that I was attempting to test for HBASE-4496 but it's
passing so still need to dig on what exactly is wrong there.
Summary
-------
Creates a new CacheConfig class and moves almost everything block cache related
into this single class. Adding new configuration params and booleans and such
should be much better.
All tests are NOT passing yet, still working on it, but wanted to have
something up today. Basically "code complete" but broken :)
This addresses bug HBASE-4422.
https://issues.apache.org/jira/browse/HBASE-4422
Diffs (updated)
-----
/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java 1177471
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1177471
/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
1177471
/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
1177471
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1177471
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1177471
/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1177471
/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1177471
/src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java 1177471
/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1177471
/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java 1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java 1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java 1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java 1177471
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java 1177471
/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
1177471
/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
1177471
/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
1177471
Diff: https://reviews.apache.org/r/2089/diff
Testing
-------
Still working through some tests that aren't passing.
Thanks,
Jonathan
> Move block cache parameters and references into single CacheConf class
> ----------------------------------------------------------------------
>
> Key: HBASE-4422
> URL: https://issues.apache.org/jira/browse/HBASE-4422
> Project: HBase
> Issue Type: Improvement
> Components: io
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.92.0
>
>
> From StoreFile down to HFile, we currently use a boolean argument for each of
> the various block cache configuration parameters that exist. The number of
> parameters is going to continue to increase as we look at compressed cache,
> delta encoding, and more specific L1/L2 configuration. Every new config
> currently requires changing many constructors because it introduces a new
> boolean.
> We should move everything into a single class so that modifications are much
> less disruptive.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
