[
https://issues.apache.org/jira/browse/HBASE-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385023#comment-14385023
]
Hadoop QA commented on HBASE-12993:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12707864/HBASE-12993.patch
against master branch at commit 0a500e5d305b0c75a6a357a5ff7a9210a615a007.
ATTACHMENT ID: 12707864
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13467//console
This message is automatically generated.
> Use HBase 1.0 interfaces in hbase-thrift
> ----------------------------------------
>
> Key: HBASE-12993
> URL: https://issues.apache.org/jira/browse/HBASE-12993
> Project: HBase
> Issue Type: Bug
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Fix For: 2.0.0, 1.0.1
>
> Attachments: HBASE-12993.patch
>
>
> hbase-thrift uses HTable and HBaesAdmin. It also uses HTablePool, which is
> an outdated concept.
> As per [~ndimiduk] on the user group:
> {quote}
> I believe HTablePool is completely eclipsed by the modern Connection
> implementation. We'll need to keep the map of UserName => Connection (or
> maybe the ConnectionCache handles this?) Probably a single Connection (per
> user) with a large thread pool will do the trick.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
