[
https://issues.apache.org/jira/browse/HBASE-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385649#comment-14385649
]
Hadoop QA commented on HBASE-12993:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708022/HBASE-12993-1.patch
against master branch at commit ced0e324a190e75d8a93b8b09676781853819361.
ATTACHMENT ID: 12708022
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13481//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13481//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13481//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13481//console
This message is automatically generated.
> Use HBase 1.0 interfaces in hbase-thrift
> ----------------------------------------
>
> Key: HBASE-12993
> URL: https://issues.apache.org/jira/browse/HBASE-12993
> Project: HBase
> Issue Type: Bug
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Fix For: 2.0.0, 1.0.1
>
> Attachments: HBASE-12993-1.patch, HBASE-12993.patch
>
>
> hbase-thrift uses HTable and HBaesAdmin. It also uses HTablePool, which is
> an outdated concept.
> As per [~ndimiduk] on the user group:
> {quote}
> I believe HTablePool is completely eclipsed by the modern Connection
> implementation. We'll need to keep the map of UserName => Connection (or
> maybe the ConnectionCache handles this?) Probably a single Connection (per
> user) with a large thread pool will do the trick.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
