[
https://issues.apache.org/jira/browse/HBASE-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385675#comment-14385675
]
Ashish Singhi commented on HBASE-13296:
---------------------------------------
Looks ok to me.
minor nits,
Can we create local variables for the return values of this methods and avoid
repetitive calls to this methods.
{code}
TEST_UTIL.getMiniHBaseCluster().getMaster()
table.getNameAsString()
convertToNamespace(ns)
{code}
Why not use assertNotEquals and assertEquals here
{code}
+ assertTrue(ZKUtil.checkExists(zkw, baseAclZNode + table.getNameAsString())
!= -1);
+ assertTrue(ZKUtil.checkExists(zkw, baseAclZNode + convertToNamespace(ns))
!= -1);
{code}
{code}
+ assertTrue(ZKUtil.checkExists(zkw, baseAclZNode + table.getNameAsString())
== -1);
+ assertTrue(ZKUtil.checkExists(zkw, baseAclZNode + convertToNamespace(ns))
== -1);
{code}
> Fix the deletion of acl notify nodes for namespace.
> ---------------------------------------------------
>
> Key: HBASE-13296
> URL: https://issues.apache.org/jira/browse/HBASE-13296
> Project: HBase
> Issue Type: Bug
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Priority: Minor
> Attachments: HBASE-13296.patch, HBASE-13296_v2.patch
>
>
> Though we're clearing the permissions of namespaces in AccessControlLists,
> we're not taking care of clearing acl znodes related to namespace. Looking at
> the code, we're taking care of this case with tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
