[
https://issues.apache.org/jira/browse/HBASE-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385679#comment-14385679
]
Srikanth Srungarapu commented on HBASE-13296:
---------------------------------------------
Extracted a local variable for master, as it saved 3 occurrences. We already
have local variables for table name and namespace. I don't think creating again
local variables for table.getNameAsString() and convertToNamespace(ns) can save
us a lot, especially given the fact there are only 2 occurrences.
If znode exists, the version number is returned.
{code}
* @return version of the node if it exists, -1 if does not exist
{code}
Thought it would be easier to restrict ourselves to check for existence or not,
in which case assertTrue would be better choice. For consistency sake, I used
it for throughout. Let's see what other folks would suggest. If they have other
opinions, I would be happy to change.
> Fix the deletion of acl notify nodes for namespace.
> ---------------------------------------------------
>
> Key: HBASE-13296
> URL: https://issues.apache.org/jira/browse/HBASE-13296
> Project: HBase
> Issue Type: Bug
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Priority: Minor
> Attachments: HBASE-13296.patch, HBASE-13296_v2.patch,
> HBASE-13296_v2.patch
>
>
> Though we're clearing the permissions of namespaces in AccessControlLists,
> we're not taking care of clearing acl znodes related to namespace. Looking at
> the code, we're taking care of this case with tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
