[
https://issues.apache.org/jira/browse/HBASE-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388541#comment-14388541
]
Hadoop QA commented on HBASE-11425:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708404/HBASE-11425.patch
against master branch at commit f1f4b6618334767d0da0f47965309b21676e7e9f.
ATTACHMENT ID: 12708404
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 246
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:red}-1 javac{color}. The applied patch generated 63 javac compiler
warnings (more than the master's current 46 warnings).
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
14 warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2050 checkstyle errors (more than the master's current 1926 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ByteBufferUtils.copyFromBufferToByteArray(val, getValueBuffer(),
getValueOffset(), 0, getValueLength());
+ ByteBufferUtils.copyFromBufferToByteArray(fam, getFamilyBuffer(),
getFamilyOffset(), 0, getFamilyLength());
+ ByteBufferUtils.copyFromBufferToByteArray(qual, getQualifierBuffer(),
getQualifierOffset(), 0, getQualifierLength());
+ ByteBufferUtils.copyFromBufferToByteArray(row, getRowBuffer(),
getRowOffset(), 0, getRowLength());
+ ByteBufferUtils.copyFromBufferToByteArray(minimumMidpointArray, right,
rightOffset, 0, diffIdx + 1);
+ ByteBufferUtils.copyFromBufferToByteArray(minimumMidpointArray, left,
leftOffset, 0, diffIdx);
+ ByteBufferUtils.copyFromBufferToByteArray(minimumMidpointArray, right,
rightOffset, 0, diffIdx + 1);
+ return matchingFamily(left, left.getFamilyOffset(),
left.getFamilyLength(), buf, offset, length);
+ cell.getFamilyArray(), cell.getFamilyOffset(),
cell.getFamilyLength(), cell.getQualifierArray(),
+ public static int findCommonPrefixInQualifierPart(Cell left, Cell right, int
qualifierCommonPrefix) {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13505//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13505//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13505//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13505//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13505//console
This message is automatically generated.
> Cell/DBB end-to-end on the read-path
> ------------------------------------
>
> Key: HBASE-11425
> URL: https://issues.apache.org/jira/browse/HBASE-11425
> Project: HBase
> Issue Type: Umbrella
> Components: regionserver, Scanners
> Affects Versions: 0.99.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-11425-E2E-NotComplete.patch, HBASE-11425.patch,
> Offheap reads in HBase using BBs_V2.pdf, Offheap reads in HBase using
> BBs_final.pdf
>
>
> Umbrella jira to make sure we can have blocks cached in offheap backed cache.
> In the entire read path, we can refer to this offheap buffer and avoid onheap
> copying.
> The high level items I can identify as of now are
> 1. Avoid the array() call on BB in read path.. (This is there in many
> classes. We can handle class by class)
> 2. Support Buffer based getter APIs in cell. In read path we will create a
> new Cell with backed by BB. Will need in CellComparator, Filter (like SCVF),
> CPs etc.
> 3. Avoid KeyValue.ensureKeyValue() calls in read path - This make byte copy.
> 4. Remove all CP hooks (which are already deprecated) which deal with KVs.
> (In read path)
> Will add subtasks under this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
