[
https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390172#comment-14390172
]
Hadoop QA commented on HBASE-13373:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708628/13373.txt
against master branch at commit 6415742c3757ca72080ca63372d1a0f82ac7607e.
ATTACHMENT ID: 12708628
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 36 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13516//console
This message is automatically generated.
> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader;
> ditto for Scanners and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13373
> URL: https://issues.apache.org/jira/browse/HBASE-13373
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments: 13373.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline
> because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the
> clear with V3 enabled since hbase 1.0.0; we can have just an Interface and an
> implementation. If we need to support a new hfile type, can hopefully do it
> in a backward compatible way now we have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is
> going on when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old
> classes as soon as I have something working. I don't believe we write
> classnames into our data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
