[
https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391407#comment-14391407
]
Hadoop QA commented on HBASE-13373:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708759/0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch
against master branch at commit 485800830a58da1af31beaac859d99b56d823f99.
ATTACHMENT ID: 12708759
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 61 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ this.hfileContext.setFileCreateTime(creationTimeBytes == null ? 0 :
Bytes.toLong(creationTimeBytes));
+ || (majorVersion == 2 && reader.getHFileMinorVersion() >=
HFileReaderImpl.MINOR_VERSION_WITH_CHECKSUM);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver.testCoprocessorHooksInRegionsMerge(TestRegionServerObserver.java:100)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13522//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13522//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13522//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13522//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13522//console
This message is automatically generated.
> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader;
> ditto for Scanners and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13373
> URL: https://issues.apache.org/jira/browse/HBASE-13373
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments:
> 0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch, 13373.txt,
> 13373.v3.txt, 13373.v3.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline
> because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the
> clear with V3 enabled since hbase 1.0.0; we can have just an Interface and an
> implementation. If we need to support a new hfile type, can hopefully do it
> in a backward compatible way now we have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is
> going on when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old
> classes as soon as I have something working. I don't believe we write
> classnames into our data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
