[ 
https://issues.apache.org/jira/browse/HBASE-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391878#comment-14391878
 ] 

Hadoop QA commented on HBASE-6143:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12708729/HBASE-6143-v1.patch
  against master branch at commit 485800830a58da1af31beaac859d99b56d823f99.
  ATTACHMENT ID: 12708729

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 20 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 6 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1937 checkstyle errors (more than the master's current 1924 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +      BulkAssigner ba = new GeneralBulkAssigner(this.server, bulkPlan, 
this, bulkAssignWaitTillAllAssigned);
+                                        Map<HRegionInfo, ServerName> suggest) 
throws HBaseIOException {
+//      LOG.debug("testImmediateAssignment with " + mock[0] + " regions and " 
+ mock[1] + " servers");

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
                  org.apache.hadoop.hbase.master.handler.TestEnableTableHandler
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.master.TestMaster
                  org.apache.hadoop.hbase.client.TestAdmin1
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.master.TestRegionPlacement

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s):       
at 
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver.testCoprocessorHooksInRegionsMerge(TestRegionServerObserver.java:100)
        at 
org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation.testMasterKeyRotation(TestEncryptionKeyRotation.java:189)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//artifact/patchprocess/patchReleaseAuditWarnings.txt
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13527//console

This message is automatically generated.

> Make region assignment smarter when regions are re-enabled.
> -----------------------------------------------------------
>
>                 Key: HBASE-6143
>                 URL: https://issues.apache.org/jira/browse/HBASE-6143
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>         Attachments: 6143-v1.txt, 6143-v2.txt, 6143-v3.txt, 
> HBASE-6143-0.patch, HBASE-6143-1.patch, HBASE-6143-v1.patch
>
>
> Right now a random region server is picked when re-enabling a table. This 
> could be much smarter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to