[
https://issues.apache.org/jira/browse/HBASE-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393830#comment-14393830
]
Hadoop QA commented on HBASE-6143:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12709085/HBASE-6143-v2.patch
against master branch at commit 2365932d78180255be7145d8d247ee1f801aed1d.
ATTACHMENT ID: 12709085
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 20 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1940 checkstyle errors (more than the master's current 1924 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ BulkAssigner ba = new GeneralBulkAssigner(this.server, bulkPlan,
this, bulkAssignWaitTillAllAssigned);
+ Map<ServerName, ServerName> noTimeToCurrent = new
HashMap<ServerName,ServerName>(clusterState.size());
+ Map<HRegionInfo, ServerName> initialLocation = new HashMap<HRegionInfo,
ServerName>(regions.size());
+ sn = noTimeToCurrent.get(ServerName.valueOf(old.getHostname(),
old.getPort(), ServerName.NON_STARTCODE));
+ Map<HRegionInfo, ServerName> suggest)
throws HBaseIOException {
+// conf.setClass("hbase.util.ip.to.rack.determiner", MockMapping.class,
DNSToSwitchMapping.class);
+// clusterState.put(servers[5], list1); //servers[5], rack2 hosts
replica_of_region1 and replica_of_region2
+// clusterState.put(servers[10], new ArrayList<HRegionInfo>());
//servers[10], rack3 hosts no region
+// Map<ServerName, List<HRegionInfo>> clusterState = new
HashMap<ServerName, List<HRegionInfo>>();
+// assertEquals(10, cluster.numServers); // only 10 servers because they
share the same host + port
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMaster
org.apache.hadoop.hbase.master.TestRegionPlacement
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.util.TestMergeTable
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.client.TestAdmin1
{color:red}-1 core zombie tests{color}. There are 6 zombie test(s):
at
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testRestoreSnapshot(TestRestoreSnapshotFromClient.java:147)
at
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testRestoreSnapshot(TestRestoreSnapshotFromClient.java:147)
at
org.apache.hadoop.hbase.client.TestHCM.testConnectionClose(TestHCM.java:327)
at
org.apache.hadoop.hbase.client.TestHCM.testConnectionCloseAllowsInterrupt(TestHCM.java:280)
at
org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient.testRestoreSnapshot(TestRestoreFlushSnapshotFromClient.java:151)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsInScanThatDoesNotMatchAnyDefinedLabels(TestVisibilityLabels.java:255)
at
org.apache.hadoop.hbase.client.TestSnapshotMetadata.testDescribeOnEmptyTableMatchesAfterMetadataChangeAndRestore(TestSnapshotMetadata.java:248)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13545//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13545//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13545//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13545//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13545//console
This message is automatically generated.
> Make region assignment smarter when regions are re-enabled.
> -----------------------------------------------------------
>
> Key: HBASE-6143
> URL: https://issues.apache.org/jira/browse/HBASE-6143
> Project: HBase
> Issue Type: Improvement
> Components: Balancer
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Attachments: 6143-v1.txt, 6143-v2.txt, 6143-v3.txt,
> HBASE-6143-0.patch, HBASE-6143-1.patch, HBASE-6143-v1.patch,
> HBASE-6143-v2.patch
>
>
> Right now a random region server is picked when re-enabling a table. This
> could be much smarter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
