[
https://issues.apache.org/jira/browse/HBASE-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392801#comment-14392801
]
Josh Elser commented on HBASE-13351:
------------------------------------
Thanks for the review.
bq. QosPriority now needs to have javadoc IMO
Easy enough.
bq. on the other hand, avoiding having to add one more thread pool for this
class of methods would be either
I didn't think the attached patch actually changed the threadpools that were
created (at least with SimpleRpcScheduler). Perhaps I missed something?
bq. do you think these RPCs should go with admin QoS, or we should have
something with lower QoS (say, 50?)
I think that makes sense. Let me see if I can put up a new patch that does 50
like you suggest.
> Annotate internal MasterRpcServices methods with admin priority
> ---------------------------------------------------------------
>
> Key: HBASE-13351
> URL: https://issues.apache.org/jira/browse/HBASE-13351
> Project: HBase
> Issue Type: Improvement
> Components: master
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-13351-v1.patch, HBASE-13351.patch
>
>
> HBASE-12071, among other things, introduced annotating RPC methods to give
> certain methods priority over others. Namely, this helps ensure that client
> requests cannot starve out internal RPC between master and regionserver.
> Similarly, we can do the same thing for Master RPC methods that are invoked
> by RS's.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
