[
https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395516#comment-14395516
]
Hudson commented on HBASE-13373:
--------------------------------
SUCCESS: Integrated in HBase-1.1 #358 (See
[https://builds.apache.org/job/HBase-1.1/358/])
Revert "HBASE-13373 Squash HFileReaderV3 together with HFileReaderV2 and
AbstractHFileReader; ditto for Scanners and BlockReader, etc.:" (stack: rev
e65f430003aa86d8a138b631bd9f3af86c826461)
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterFactory.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileInlineToRootChunkConversion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV3.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestFixedFileTrailer.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV3.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLazyDataBlockDecompression.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java
> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader;
> ditto for Scanners and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13373
> URL: https://issues.apache.org/jira/browse/HBASE-13373
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.1.0
>
> Attachments:
> 0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch, 13373.txt,
> 13373.v3.txt, 13373.v3.txt, 13373.v5.txt, 13373.v6.txt, 13373.v6.txt,
> 13373.v6.txt, 13373.v6.txt, 13373.v6.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline
> because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the
> clear with V3 enabled since hbase 1.0.0; we can have just an Interface and an
> implementation. If we need to support a new hfile type, can hopefully do it
> in a backward compatible way now we have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is
> going on when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old
> classes as soon as I have something working. I don't believe we write
> classnames into our data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
