[ 
https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485604#comment-14485604
 ] 

Sean Busbey commented on HBASE-13373:
-------------------------------------

{quote}
You cannot go to 1.0 from anything before 0.98.
{quote}

You can't do a rolling upgrade to 1.0 from before 0.98, but the upgrade docs 
are a little unclear on full-restart upgrade from earlier versions.

There's a note that calls out that rolling from 0.96 doesn't work for a few 
reasons (which implies that full-restart does work?). The [instructions for 
getting from 0.94 to 
1.0|http://hbase.apache.org/book.html#upgrade1.0.from.0.94] expressly tells 
folks to follow the "upgrade to 0.96" instructions while substituting 1.0.0 for 
0.96. Do those instructions leave you with a cluster that only has HFile v2.3?

> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; 
> ditto for Scanners and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13373
>                 URL: https://issues.apache.org/jira/browse/HBASE-13373
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 
> 0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch, 13373.txt, 
> 13373.v3.txt, 13373.v3.txt, 13373.v5.txt, 13373.v6.txt, 13373.v6.txt, 
> 13373.v6.txt, 13373.v6.txt, 13373.v6.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline 
> because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the 
> clear with V3 enabled since hbase 1.0.0; we can have just an Interface and an 
> implementation.  If we need to support a new hfile type, can hopefully do it 
> in a backward compatible way now we have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is 
> going on when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old 
> classes as soon as I have something working. I don't believe we write 
> classnames into our data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to