[ 
https://issues.apache.org/jira/browse/HBASE-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481502#comment-14481502
 ] 

Andrew Purtell commented on HBASE-13391:
----------------------------------------

Just to clarify, there are two test failure cases I've discussed above:
# An intermittent failure where the timing of a bunch of asynchronous activity 
is slightly different, so recovery is still happening, and so we see "got 0 
expected 1".
# If distributed replay is turned off, then we see "got 3 expected 1"

bq. If there's still recovery happening then that would explain the "saw 0" 
failure.

That is my take.

bq. Does the test actually attempt to verify that replay is done?

It does not appear to, and I think this would fix the problem as reported on 
this issue's description.

bq. Is the failure log with distributed log replay off? I'll have to dig in 
some to figure out what would lead to seeing 3x the recovery.

I was thinking that we could turn off distributed replay, to achieve the same 
aim as adding code to the test to wait for replay to finish. However then the 
test fails with "got 3 expected 1". 

> TestRegionObserverInterface frequently failing on branch-1 
> -----------------------------------------------------------
>
>                 Key: HBASE-13391
>                 URL: https://issues.apache.org/jira/browse/HBASE-13391
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: test.log.fail.txt, test.log.pass.txt
>
>
> TestRegionObserverInterface is frequently failing on branch-1 .
> Example:
> {noformat}
> java.lang.AssertionError: Result of 
> org.apache.hadoop.hbase.coprocessor.SimpleRegionObserver$Legacy.getCtPreWALRestore
>  is expected to be 1, while we get 0
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at 
> org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.verifyMethodResult(TestRegionObserverInterface.java:751)
>       at 
> org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testLegacyRecovery(TestRegionObserverInterface.java:685)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to