[
https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485718#comment-14485718
]
Ted Yu commented on HBASE-13427:
--------------------------------
lgtm
nit:
{code}
878 if (obj != null)
879 return ((StoreScanner) obj).storeScannerID ==
this.storeScannerID;
{code}
Please enclose the return statement in curly braces.
> HStore#addChangedReaderObserver hotspots due to missing hashCode and equals
> on StoreScanner
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-13427
> URL: https://issues.apache.org/jira/browse/HBASE-13427
> Project: HBase
> Issue Type: Bug
> Reporter: John Leach
> Assignee: John Leach
> Attachments: HBASE-13427.patch, SetFromMap.add_Runnable.tiff
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Please see attached graph...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
