[ 
https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487588#comment-14487588
 ] 

Elliott Clark commented on HBASE-13427:
---------------------------------------

Probably better to check the type of obj rather than just assume it. Equals is 
supposed to be throw free.
storeScannerSequence should be final.
storeScannerID should also be final too.

> HStore#addChangedReaderObserver hotspots due to missing hashCode and equals 
> on StoreScanner
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13427
>                 URL: https://issues.apache.org/jira/browse/HBASE-13427
>             Project: HBase
>          Issue Type: Bug
>            Reporter: John Leach
>            Assignee: John Leach
>         Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, 
> HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Please see attached graph...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to